-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GHC 9.4 #49
Update to GHC 9.4 #49
Conversation
Hi @9999years! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
48d7b00
to
415e5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for this effort.
Three things:
- We currently don't have CI enabled for 9.4. It would make sense to add that as part of this PR.
- Can you please sign the Facebook CLA check so that we can commit this change?
- There seems to be an accidental change in the code that I've pointed out.
Thanks. I am going to work on CI setup now. For CLA, we are currently waiting for the internal process on our side. :-) |
OK, the CLA is signed and should be good now. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@josefs : to check with CI, we need an approval for running workflows as you can see in this github message box. Would you or any repo maintainer do that for us? Thank you very much! |
Many thanks for your contribution! Merged. |
Thanks! Let us know when you've cut a release, it'll be helpful for getting the |
retire 1.2.1 is now in Hackage |
This updates
retrie
for compatibility with GHC 9.4, which is necessary for improved GHC 9.4 support fromhaskell-language-server
.HLS PR based on these changes: haskell/haskell-language-server#3317