Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GHC 9.4 #49

Merged
merged 24 commits into from
Nov 11, 2022
Merged

Conversation

9999years
Copy link
Contributor

@9999years 9999years commented Nov 2, 2022

This updates retrie for compatibility with GHC 9.4, which is necessary for improved GHC 9.4 support from haskell-language-server.

HLS PR based on these changes: haskell/haskell-language-server#3317

@facebook-github-bot
Copy link
Contributor

Hi @9999years!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

@josefs josefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for this effort.

Three things:

  • We currently don't have CI enabled for 9.4. It would make sense to add that as part of this PR.
  • Can you please sign the Facebook CLA check so that we can commit this change?
  • There seems to be an accidental change in the code that I've pointed out.

Retrie/Expr.hs Outdated Show resolved Hide resolved
@wavewave
Copy link
Contributor

wavewave commented Nov 9, 2022

Thanks. I am going to work on CI setup now. For CLA, we are currently waiting for the internal process on our side. :-)

@9999years
Copy link
Contributor Author

OK, the CLA is signed and should be good now.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 9, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@9999years 9999years marked this pull request as ready for review November 10, 2022 16:07
@9999years 9999years requested a review from josefs November 10, 2022 16:08
@wavewave
Copy link
Contributor

@josefs : to check with CI, we need an approval for running workflows as you can see in this github message box. Would you or any repo maintainer do that for us? Thank you very much!
Screen Shot 2022-11-10 at 1 33 43 PM

@josefs josefs merged commit fb58d04 into facebookincubator:main Nov 11, 2022
@josefs
Copy link

josefs commented Nov 11, 2022

Many thanks for your contribution! Merged.

@9999years 9999years deleted the mercury/ghc94 branch November 11, 2022 14:42
@9999years
Copy link
Contributor Author

Thanks! Let us know when you've cut a release, it'll be helpful for getting the haskell-language-server support in place.

@pepeiborra
Copy link
Contributor

Thanks! Let us know when you've cut a release, it'll be helpful for getting the haskell-language-server support in place.

retire 1.2.1 is now in Hackage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants